This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix DW_CFA_restore_extended parsing
- From: "Jim Blandy" <jimb at red-bean dot com>
- To: luisgpm at linux dot vnet dot ibm dot com
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 20 Dec 2007 14:03:53 -0800
- Subject: Re: [PATCH] Fix DW_CFA_restore_extended parsing
- References: <1198182171.9817.22.camel@gargoyle>
On Dec 20, 2007 12:22 PM, Luis Machado <luisgpm@linux.vnet.ibm.com> wrote:
> This simple patch fixes the issue. Any thoughts? Ok to commit?
The only difference between those two opcodes is in their encoding ---
the action to be performed is identical. It seems silly to duplicate
the code. Could you pull the common code out into its own function,
and then have both cases simply parse their arguments and call the
function?