This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix DW_CFA_restore_extended parsing

From: "Jim Blandy" <jimb at red-bean dot com>
To: luisgpm at linux dot vnet dot ibm dot com
Cc: gdb-patches at sourceware dot org
Date: Fri, 21 Dec 2007 11:03:07 -0800
Subject: Re: [PATCH] Fix DW_CFA_restore_extended parsing
References: <1198182171.9817.22.camel@gargoyle> <8f2776cb0712201403j593ffc0bg846b1a654a09d8bb@mail.gmail.com> <1198245586.9817.29.camel@gargoyle>

On Dec 21, 2007 5:59 AM, Luis Machado <luisgpm@linux.vnet.ibm.com> wrote:
> On Thu, 2007-12-20 at 14:03 -0800, Jim Blandy wrote:
> > The only difference between those two opcodes is in their encoding ---
> > the action to be performed is identical.  It seems silly to duplicate
> > the code.  Could you pull the common code out into its own function,
> > and then have both cases simply parse their arguments and call the
> > function?
>
> Like so?

Yes --- looks great.  Please commit.  Thanks!

Follow-Ups:
- Re: [PATCH] Fix DW_CFA_restore_extended parsing
  - From: Luis Machado

References:
- [PATCH] Fix DW_CFA_restore_extended parsing
  - From: Luis Machado
- Re: [PATCH] Fix DW_CFA_restore_extended parsing
  - From: Jim Blandy
- Re: [PATCH] Fix DW_CFA_restore_extended parsing
  - From: Luis Machado

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]