This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit/Ada] Attach ada_executable_changed_observer
- From: Daniel Jacobowitz <drow at false dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 29 Dec 2007 19:33:17 -0500
- Subject: Re: [commit/Ada] Attach ada_executable_changed_observer
- References: <20071229054146.GD30002@adacore.com>
On Fri, Dec 28, 2007 at 09:41:46PM -0800, Joel Brobecker wrote:
> In a change I made a few months ago, I defined a function that was
> meant to be attached as an observer of the executable-changed
> notification, but never actually attached it. Not sure if I forgot,
> or that piece was missing from the patch. The part that I don't
> understand is why I didn't get a warning from the compiler, since
> the function is static but unused.
We deliberately do not use -Wunused or any of the more specific unused
warnings. I think we should use them and mark unused
parameters to functions with ATTRIBUTE_UNUSED, or else use them except
for the unused parameter warnings; turning it on would take someone
motivated to clean up all the resulting -Werror build failures.
--
Daniel Jacobowitz
CodeSourcery