This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Handle solaris dynamic linker name change.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 3 Jan 2008 21:49:51 -0800
- Subject: Re: [RFA] Handle solaris dynamic linker name change.
- References: <200712242048.33983.vladimir@codesourcery.com>
Hi Volodya,
> The solutions are:
> 1. Stop gdb from thinking dynamic linker was unloaded
> 2. Revive re_enable_breakpoints_in_shlibs
> 3. Make breakpoint_re_set one try to re-enable bp_shlib_event
>
> I think (1) is best, since it will make (2) or (3) unnecessary.
I agree.
> Ignore change in name of dynamic linker during
> execution. This also unbreaks pending breakpoints.
> * solist.h (struct target_so_ops): New field
> same.
> * solib-svr4.c (svr4_same): New.
> (_initialize_svr4_solib): Register svr4_same.
> * solib.c (update_solib_list): Use ops->same,
> if available.
I really liked the idea of the patch, but I think your change
will affect more than just solaris. the solib-svr4 target_so_ops
is used by many targets, not just solaris ones.
Within the same idea, how about making this a gdbarch method/function?
The default value would be a function that does a *filename_cmp*
(first improvement introduced by your patch ;-), and on solaris,
we would provide a function that first does a filename_cmp, and
if that fails, then looks at the specific name.
I'd like the feedback from other maintainers about this.
Thanks,
--
Joel