This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [libiberty] don't demangle functions named "."
- From: Jim Blandy <jimb at codesourcery dot com>
- To: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 09 Jan 2008 11:26:27 -0800
- Subject: Re: [libiberty] don't demangle functions named "."
- References: <1199898911.15225.48.camel@localhost.localdomain>
Thiago Jung Bauermann <bauerman at br.ibm.com> writes:
> @@ -2513,10 +2510,12 @@ iterate_demangle_function (struct work_s
>
> while (scan[2])
> {
> - demangle_function_name (work, mangled, declp, scan);
> - success = demangle_signature (work, mangled, declp);
> - if (success)
> - break;
> + if (demangle_function_name (work, mangled, declp, scan))
> + {
> + success = demangle_signature (work, mangled, declp);
> + if (success)
> + break;
> + }
>
> /* Reset demangle state for the next round. */
> *mangled = mangle_init;
Why not simply:
if (demangle_function_name (work, mangled, declp, scan)
&& demangle_signature (work, mangled, declp))
break;