This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [RFA] win32-nat.c: Restore wrongly removed code that closes two handles returned by CreateProcess

From: "Pierre Muller" <muller at ics dot u-strasbg dot fr>
To: <gdb-patches at sourceware dot org>
Date: Mon, 14 Jan 2008 09:02:45 +0100
Subject: RE: [RFA] win32-nat.c: Restore wrongly removed code that closes two handles returned by CreateProcess
References: <001301c85476$4eff2fc0$ecfd8f40$@u-strasbg.fr> <20080111183146.GA27708@ednor.casa.cgf.cx>

 
> No need to apologize! I'm glad you caught this and I'm glad that you
> researched your earlier changes.  I actually stumbled across your
> initial bug separately last week while debugging something with an
> older
> version of gdb.  So, I'm happy that you fixed it.
> 
> >ChangeLog entry:
> >
> >2008-01-11  Pierre Muller  <muller@ics.u-strasbg.fr>
> >
> >	* win32-nat.c (win32_create_inferior): Restore
> >	code calling CloseHandle on ProcessInformation structure.
> 
> Please check in.  I'm sorry that I didn't catch this when I reviewed
> your change.  It's obvious in perfect 20-20 hindsight.

Done, thanks,

Pierre Muller

References:
- [RFA] win32-nat.c: Restore wrongly removed code that closes two handles returned by CreateProcess
  - From: Pierre Muller
- Re: [RFA] win32-nat.c: Restore wrongly removed code that closes two handles returned by CreateProcess
  - From: Christopher Faylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]