This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Make mi_cmd_break_insert exception-safe.
On Monday 28 January 2008 00:10:21 Nick Roberts wrote:
> > The attached patch make mi_cmd_break_insert exception-safe, so that it always
> > resets the hook it installs. There's new testcase that fails before the
> > patch, and works after. OK?
>
> Is this patch is on top of your earlier one?
Yes.
> If so, I think that has to be
> approved before we can review this one. In fact there appear to be many
> changes in the pipeline that need to be resolved before the next release.
>
> > - Volodya
> >
> > [gdb]
> > * breakpoint.c (break_command_1): Return void.
> ^^^^^^^^^^^
> That's a contradiction in terms, isn't it?
Not sure. C++ allows
return <expression-of-type-void>;
I suspect modern C allows as well, so terminologically,
this is fine.
- Volodya