This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Support exec tracing on GNU/Linux and HP-UX
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 29 Jan 2008 13:16:57 -0800
- Subject: Re: [RFC] Support exec tracing on GNU/Linux and HP-UX
- References: <20071019175920.GA548@caradoc.them.org> <20071022043831.GD764@adacore.com> <20071022114328.GA1421@caradoc.them.org> <20071022184702.GG764@adacore.com> <20071022185627.GH764@adacore.com> <20071022193024.GA16312@caradoc.them.org> <20071221153039.GO6154@adacore.com> <20080129170835.GC2815@caradoc.them.org>
Hi Daniel,
First of all, thanks very much for the mega-load of reviews you did
today. I was hoping for a more positive result, of course :-), but
it's interesting to get your opinion and we can start some discussions.
> > 2007-12-21 Joel Brobecker <brobecker@adacore.com>
> >
> > * infrun.c (wait_for_inferior): Add treat_exec_as_sigtrap parameter
> > and use it.
> > (proceed, start_remote): Update call to wait_for_inferior.
> > * inferior.h (wait_for_inferior): Update declaration.
> > * fork-child.c, infcmd.c, solib-irix.c, solib-osf.c, solib-sunos.c,
> > solib-svr4.c, win32-nat.c: Update calls to wait_for_inferior.
> > * inf-ttrace.c (inf_ttrace_wait): Report TTEVT_EXEC events as
> > TARGET_WAITKIND_EXECD instead of TARGET_WAITKIND_STOPPED.
> >
> > Tested on hppa-hpux, no regression.
> This looks good to me - would you add that comment and check it in?
Absolutely. Here is the comment that I added:
If TREAT_EXEC_AS_SIGTRAP is non-zero, then handle EXEC signals
as if they were SIGTRAP signals. This can be useful during
the startup sequence on some targets such as HP/UX, where
we receive an EXEC event instead of the expected SIGTRAP.
Hope this is clear enough.
Do you want to push your patch for the 6.8 release or would you
rather wait for the next one?
--
Joel