Re: [RFC] Support exec tracing on GNU/Linux and HP-UX

[Joel Brobecker <brobecker at adacore dot com>]

Hi Daniel,

First of all, thanks very much for the mega-load of reviews you did
today. I was hoping for a more positive result, of course :-), but
it's interesting to get your opinion and we can start some discussions.

> > 2007-12-21  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * infrun.c (wait_for_inferior): Add treat_exec_as_sigtrap parameter
> >         and use it.
> >         (proceed, start_remote): Update call to wait_for_inferior.
> >         * inferior.h (wait_for_inferior): Update declaration.
> >         * fork-child.c, infcmd.c, solib-irix.c, solib-osf.c, solib-sunos.c,
> >         solib-svr4.c, win32-nat.c: Update calls to wait_for_inferior.
> >         * inf-ttrace.c (inf_ttrace_wait): Report TTEVT_EXEC events as
> >         TARGET_WAITKIND_EXECD instead of TARGET_WAITKIND_STOPPED.
> > 
> > Tested on hppa-hpux, no regression.

> This looks good to me - would you add that comment and check it in?

Absolutely. Here is the comment that I added:

   If TREAT_EXEC_AS_SIGTRAP is non-zero, then handle EXEC signals
   as if they were SIGTRAP signals.  This can be useful during
   the startup sequence on some targets such as HP/UX, where
   we receive an EXEC event instead of the expected SIGTRAP.

Hope this is clear enough.

Do you want to push your patch for the 6.8 release or would you
rather wait for the next one?

-- 
Joel