This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Printing decimal128 types out of registers


On Wed, 2008-01-30 at 19:11 +0100, Mark Kettenis wrote:
> > Is this ok?
> 
> Looks mostly reasonable to me, but I don't see why you need
> ppc_dl0_upper_regnum, and ppc_dl15_regnum.

ppc_dl0_upper_regnum is used ppc_pseudo_register_{read,write}. Are you
saying that given it always has the value of ppc_fp0_regnum, I should
use that instead? Could be, but then there's the lack of symmetry in
using an fp variable in dl-related code. But that's minor. 

ppcdl15_regnum is indeed unused. I kept it also for symmetry reasons,
since there's ppc_ev31_regnum. But it can be removed (specially if the
later is removed as well as you suggested).
-- 
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]