This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] -var-evaluate-expression NAME [FORMAT]

From: Joel Brobecker <brobecker at adacore dot com>
To: Marc Khouzam <marc dot khouzam at ericsson dot com>
Cc: Vladimir Prus <ghost at cs dot msu dot su>, gdb-patches at sources dot redhat dot com
Date: Sun, 3 Feb 2008 12:42:12 -0800
Subject: Re: [Patch] -var-evaluate-expression NAME [FORMAT]
References: <20080129214347.GC15063@caradoc.them.org> <6D19CA8D71C89C43A057926FE0D4ADAA04290E7D@ecamlmw720.eamcs.ericsson.se> <E1JLGPo-0002eW-4k@zigzag.lvk.cs.msu.su> <6D19CA8D71C89C43A057926FE0D4ADAA04E1BC29@ecamlmw720.eamcs.ericsson.se>

> I went through the file and replaced any starting sequence of
> 8 spaces with a tab.  I hesitated at changing parts of the file
> I didn't actually change, but since they were minor changes,
> I though it would make the file more readable.

We usually prefer it if you do the reformatting in a separate patch.
It makes it easier to review the non-reformatting bits by not drowning
the meat of your patch with other, less critical, hunks.

-- 
Joel

Follow-Ups:
- Re: [Patch] -var-evaluate-expression NAME [FORMAT]
  - From: Daniel Jacobowitz

References:
- RE: [Patch] -var-evaluate-expression NAME [FORMAT]
  - From: Marc Khouzam
- RE: [Patch] -var-evaluate-expression NAME [FORMAT]
  - From: Vladimir Prus
- RE: [Patch] -var-evaluate-expression NAME [FORMAT]
  - From: Marc Khouzam

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]