This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] patch for 2384, dangling TYPE_VPTR_BASETYPE
- From: "Doug Evans" <dje at google dot com>
- To: gdb-patches at sourceware dot org
- Date: Sun, 3 Feb 2008 14:18:53 -0800
- Subject: Re: [RFA] patch for 2384, dangling TYPE_VPTR_BASETYPE
- References: <e394668d0712131610w432ee506t38cfd4abfbf6ed7a@mail.gmail.com> <20071214002920.GA1208@caradoc.them.org> <e394668d0712201140x4608e975k4fc03063cfca4cba@mail.gmail.com> <20080130010600.GF25780@caradoc.them.org>
On Jan 29, 2008 5:06 PM, Daniel Jacobowitz <drow@false.org> wrote:
> On Thu, Dec 20, 2007 at 11:40:06AM -0800, Doug Evans wrote:
> > 2007-12-20 Doug Evans <dje@google.com>
> >
> > PR 2384
> > * gdbtypes.c (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno.
> > Return basetype, fieldno if found. All callers updated.
> > Don't cache TYPE_VPTR_FIELDNO, TYPE_VPTR_BASETYPE if from different
> > objfile.
> > * gdbtypes.h (get_vptr_fieldno): Renamed from fill_in_vptr_fieldno.
> > * symfile.h (fill_in_vptr_fieldno): Delete.
> >
> > * gdb.cp/gdb2384.exp: New file.
> > * gdb.cp/gdb2384.cc: New file.
> > * gdb.cp/gdb2384-base.h: New file.
> > * gdb.cp/gdb2384-base.cc: New file.
>
> Thanks, this looks OK. Could you please add copyright notices to the
> new test files before committing?
>
> > +gdb_start
> > +gdb_reinitialize_dir $srcdir/$subdir
> > +gdb_load ${binfile}
> > +#gdb_load_shlibs ${sofile}
>
> Why's that commented out?
Thanks.
Commenting out gdb_load_shlibs was probably a leftover from some
experimentation - I put it back.