This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Do not add partial_symbol again and again to the list

From: Daniel Jacobowitz <drow at false dot org>
To: Aleksandar Ristovski <aristovski at qnx dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 11 Feb 2008 16:09:35 -0500
Subject: Re: [patch] Do not add partial_symbol again and again to the list
References: <47B0AEC7.3070400@qnx.com> <20080211203809.GA29560@caradoc.them.org> <47B0B56F.4010607@qnx.com>

On Mon, Feb 11, 2008 at 03:51:59PM -0500, Aleksandar Ristovski wrote:
> Daniel Jacobowitz wrote:
>> On Mon, Feb 11, 2008 at 03:23:35PM -0500, Aleksandar Ristovski wrote:
>>> The attached patch checks if partial_symbol has already been added to 
>>> the list instead of adding duplicate records.
>>
>> How does this ever happen?  It seems very wrong.  Also, I am worried
>> that the linear search will be a bottleneck (this is quadratic as each
>> psymtab grows).
>
> Yes, I understand your concern about the complexity... but...

That's only part of the problem.  You have this huge duplication of
identical partial symbols within the same block.  How did that happen?
It shouldn't.  Maybe we can avoid creating them in the first place.

-- 
Daniel Jacobowitz
CodeSourcery

Follow-Ups:
- Re: [patch] Do not add partial_symbol again and again to the list
  - From: Aleksandar Ristovski

References:
- [patch] Do not add partial_symbol again and again to the list
  - From: Aleksandar Ristovski
- Re: [patch] Do not add partial_symbol again and again to the list
  - From: Daniel Jacobowitz
- Re: [patch] Do not add partial_symbol again and again to the list
  - From: Aleksandar Ristovski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]