This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Mon, Feb 11, 2008 at 05:43:22PM -0500, Aleksandar Ristovski wrote:Then I am definitely missing something big. Please correct me where I'm wrong.If one compilation unit has a list of symbols and they appear more than once... do we really need to have all duplicate records in partial symbols list? The partial symbol lookup (by symbol name) will find only the first one matching and probably cause loading the full symbols at which point all works as before.
Sure. But your patches aren't checking one compilation unit, they're checking every compilation unit in the objfile at once. That's why they found duplicates. I don't think any one compilation unit will have a duplicate.
Not sure if it is a valid indicator but I didn't have any regressions in 'make check'.
Yeah, I think I could write some testcases that were affected by this, but I'm not sure. It's tricky because if something else causes the full symtab to load, the problem won't appear.
Maybe there's some way we can avoid needing psymbols for types at all. But I think we need to have a real design and some documentation for it instead of just accidentally omitting them.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |