This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc]: Replace current_gdbarch in hppa

A Friday 15 February 2008 18:38:49, Ulrich Weigand wrote:
> This is really the wrong check. ?It should really just verify that
> no out-of-bounds access to u_offsets happens, so the line should
> just be something like:
>
> ? ?if ((unsigned) regno >= ARRAY_SIZE (u_offsets))

(Just wondering, since these things have been discussed before.)

Can any user input lead to such a stray regno?  Or are all
those off accesses really GDB bugs?  If so, why not make
it a gdb_assert or internal_error?

-- 
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]