This is the mail archive of the
mailing list for the GDB project.
Re: [RFA] exec_cleanup murder.
- From: Daniel Jacobowitz <drow at false dot org>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 14 Apr 2008 15:59:57 -0400
- Subject: Re: [RFA] exec_cleanup murder.
- References: <email@example.com>
On Mon, Apr 07, 2008 at 02:14:01PM +0300, Vladimir Prus wrote:
> What I propose is:
> - continuation is the only mechanism for running code after the target
> stops. A continuation callback gets extra parameter that tells if
> an error is occurred. If this parameter is true, the continuation
> just cleans up, and does not do any regular processing it would do on
This sounds good. But could you please name the argument error_p,
not error? As it is, it's shadowing the global function "error".
It's a shame that the logic of what to clean up ends up in two places
now. But it's better than before.
> @@ -168,9 +168,11 @@ mi_interpreter_prompt_p (void *data)
> static void
> -mi_interpreter_exec_continuation (struct continuation_arg *arg)
> +mi_interpreter_exec_continuation (struct continuation_arg *arg, int error)
I don't see any other problems with the patch, so it's OK with those