This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Avoid breakpoint query in MI
> > ? extern void current_interp_command_loop (void);
> > ? /* Returns opaque data associated with the top-level interpreter. ?*/
> > ? extern void *top_level_interpreter_data (void);
> > + extern void *interp_top_level (void);
>
> Please name this top_level_interpreter. Also, the return type
> should be "struct interp*". In fact, I have a not-yet-submitted
> patches which does just that :-)
OK.
> > *************** See set/show multiple-symbol."));
> > *** 524,530 ****
> > ?
> > ? ? /* If select_mode is "all", then do not print the multiple-choice
> > ? ? ? ?menu and act as if the user had chosen choice "1" (all). ?*/
> > ! ? if (select_mode == multiple_symbols_all)
> > ? ? ? args = "1";
> > ? ? else
> > ? ? ? {
> > --- 526,533 ----
> > ?
> > ? ? /* If select_mode is "all", then do not print the multiple-choice
> > ? ? ? ?menu and act as if the user had chosen choice "1" (all). ?*/
> > ! ? if (select_mode == multiple_symbols_all
> > ! ? ? ? || ui_out_is_mi_like_p (interp_ui_out (interp_top_level ())))
> > ? ? ? args = "1";
> > ? ? else
> > ? ? ? {
>
> I think that adding breakpoints on all symbols is better than silently
> grabbing random symbol, so the above seems fine to me. Can somebody approve
> the linespec.c bit?
I'm not sure I understand. When multiple-symbols is 'all' (the default) there
is no problem. When it's 'ask', it currently queries which we don't want to
happen in MI.
This appears to me to be an MI only change and within your domain. I don't
think authority is devolved on a file by file basis, although clearly I'm
not qualified to make such remarks.
--
Nick http://www.inet.net.nz/~nickrob