This is the mail archive of the
mailing list for the GDB project.
[PATCH] Prevent source file errors in --batch-silent mode
- From: Andrew STUBBS <andrew dot stubbs at st dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Date: Mon, 21 Apr 2008 19:13:44 +0100
- Subject: [PATCH] Prevent source file errors in --batch-silent mode
The --batch-silent option disables all output on stdout, thus silencing
GDB with no impact on the rest of the source base. However, it does
*not* silence stderr.
Most of the time this is the right thing to do, but it can lead to a
little unnecessary noise.
Specifically, given the following trivial test file:
Compiled with debug info, but with the source file *taken away*, the
debugger will produce an irritating error message if the running program
is interrupted with Ctrl-C:
$ gdb -ex run a.out -batch-silent
3 t.c: No such file or directory.
In this example the user is irritated, but in typical real world
examples the error message refers to some OS source file they've never
heard of (with a scary name like kernel.c), which may lead the user to
think there is a real problem.
The attached patch prevents GDB attempting to print the source reference
when in --batch-silent mode. The only outward evidence of this feature
was the error message, so nothing is lost. If anything it's a little
more efficient now.
2008-04-21 Andrew Stubbs <firstname.lastname@example.org>
* infrun.c (normal_stop): Don't print source location when running in
--- src.orig/gdb/infrun.c 2008-04-21 18:47:00.000000000 +0100
+++ src/gdb/infrun.c 2008-04-21 18:48:32.000000000 +0100
@@ -3170,6 +3170,11 @@ Further execution is probably impossible
+ /* If --batch-silent is enabled then there's no need to print the current
+ source location, and to try risks causing an error message about
+ missing source files. */
+ extern int batch_silent;
select_frame (get_current_frame ());
/* Print current location without a level number, if
@@ -3178,7 +3183,7 @@ Further execution is probably impossible
bpstat_print() contains the logic deciding in detail
what to print, based on the event(s) that just occurred. */
- if (stop_print_frame)
+ if (stop_print_frame && !batch_silent)