This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Support for multiple calling conventions, patch 3/3: Use calling convention information to handle differnt ABIs on sh target
On Apr 22 06:23, Eli Zaretskii wrote:
> > Date: Mon, 21 Apr 2008 22:00:51 +0200
> > From: Corinna Vinschen <vinschen@redhat.com>
> >
> > Thanks for the review. Is that better?
>
> Yes, thanks. I have only two comment now:
>
> > +@kindex set sh calling-convention @var{convention}
>
> The @kindex entry should only mention the command, not its arguments.
> So please drop the "@var{convention}" part.
>
> > "@cindex set SH Calling convention
>
> And this index entry is now redundant: the @kindex one will serve the
> same purpose.
>
> > +@kindex show sh calling-convention
> > +@cindex show SH Calling convention
>
> Same here.
Thanks. With these changes applied, I checked in the entire calling
convention patch now.
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat