Re: PR 2343 fix: signal number mismatch

[Aleksandar Ristovski <ARistovski at qnx dot com>]

Aleksandar Ristovski wrote:
> Daniel Jacobowitz wrote:
>> gdbarch.h and gdbarch.c are generated files (see the big comment at
>> the top of them).  You need to add the new function to the list in
>> gdbarch.sh instead.
>>
> 
> Hello Daniel,
> 
> I have made changes to gdbarch.sh. The attached patch is not complete (and
> the generated gdbarch.c would not produce linkable gdb) but I just wanted
to
> double-check if this is correct. After you confirm   I will add other
> necessary changes.

Added other changes anyway. The attached patch contains complete proposed
patch. Typically, targets would install their own signal translation
functions during the osabi registration. For gdb configured for the same
host and target, no translation is needed, but for other cases, in general,
it is.

This patch effectively deprecates functions "target_signal_from_host" and
"target_signal_to_host".



2008-04-22  Aleksandar Ristovski  <aristovski@qnx.com>

	PR gdb/2343
	* corelow.c (core_open): Use gdbarch_target_signal_from_host to
	translate signal numeric value from the target to GDB's enum
	target_signal.
	* gdbarch.c (gdbarch_target_signal_from_host, 
	gdbarch_target_signal_to_host, set_gdbarch_target_signal_from_host,
	set_gdbarch_target_signal_to_host): New functions. Generated by 
	gdbarch.sh.
	* gdbarch.h: Likewise.
	* gdbarch.sh: Added two new functions target_signal_from_host and
	target_signal_to_host.
	* target.h (default_target_signal_from_host, 
	default_target_signal_to_host): New functions - declarations.
	* signals/signals.c (struct gdbarch): New declaration.
	(default_target_signal_to_host, default_target_signal_from_host):
New
	functions.

Attachment: gdbarch.sh.target_signal.diff
Description: Text document