This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] New annotation for threads


> This is just an annotation equivalent of Vladimir's patch for an observer
> for new threads.

I'd really like to have others' opinions on this one.  I thought that
we weren't going to change our annotations anymore. And even though
we were not going to remove annotations for a while longer, we were
going to focuse on MI instead.

The change is sufficiently small that I'm thinking, why not, but can't
approve the suggestion just by myself.

Regarding the code itself:

> 2008-04-18  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* annotate.h: (annotate_new_thread): New extern.
> 
> 	* annotate.c (annotate_new_thread): New function.
> 
> 	* thread.c (add_thread_with_info): Use it.

How about creating a new observer for new_threads events instead of
specifically calling an annotation function from "add_thread"? Seems
much cleaner that way.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]