This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] PR gdb/1665 pending catch/throw catchpoints


On Tue, Apr 29, 2008 at 04:36:47PM -0400, Aleksandar Ristovski wrote:
> 	PR gdb/1665
> 	* breakpoint.c (create_breakpoint): Add breakpoint_ops argument and
> 	assign its value to the breakpoint created.
> 	(create_breakpoints): Add breakpoint_ops argument and pass it
> 	to create_breakpoint call.
> 	(break_command_really): Add breakpoint_ops argument and pass/assign
> 	appropriately.
> 	(break_command_1): Pass NULL as ops argument.
> 	(set_breakpoint): Pass NULL as ops argument.
> 	(print_one_exception_catchpoint): Print <PENDING> if no loc available.
> 	(handle_gnu_v3_exceptions): Call generic breakpoint code to insert
> 	catch and throw catchpoints.

Nice patch!  This is OK.

> -  update_global_location_list ();
>    return 1;
> +
>  }

Please don't add this blank line though.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]