This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Implement thread death notification.


On Friday 02 May 2008 00:03:53 Daniel Jacobowitz wrote:
> On Sat, Apr 26, 2008 at 08:21:50PM +0300, Vladimir Prus wrote:
> > 
> > We now have the 'thread-created' MI notification. This patch adds a
> > 'thread-exited' notification to match. Are non-MI bits of this
> > patch OK?
> 
> No, I don't think this is good enough.  It's "thread has exited but
> only if the target is native GNU/Linux".  While for some targets we
> will not detect thread exit until "info threads", which is
> unfortunate, at least the code to call the observer should be in
> generic code.  Can't we call it from delete_thread?

Yes, I think so. OK with that change?

> 
> Also, please do not commit without documentation for the notification.

Ehm! The documentation patch is approved last week.

- Volodya


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]