This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Regression in exec.c (print_section_info) ?
- From: Nick Roberts <nickrob at snap dot net dot nz>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 2 May 2008 13:05:02 +1200
- Subject: Re: Regression in exec.c (print_section_info) ?
- References: <18453.10856.678467.961230@kahikatea.snap.net.nz> <20080429030510.GA28505@adacore.com> <18454.51085.276103.301144@kahikatea.snap.net.nz> <20080501180625.GC3801@adacore.com>
>...
> > I didn't really think of it as a patch, I was just trying to draw
> > attention to the regression.
>
> This approach is too casual for me. Everyone else writes a ChangeLog,
> which takes at most 1 min of your time. Please follow this part of
> the procedure, so that I can review the ChangeLog entry as well.
It was only a one-liner and I was hoping that whoever made the regression would
correct it, perhaps as part of a bigger patch/picture. With respect I think,
perhaps, you're shooting the messenger.
>...
> > Actually it was a context diff - so you can read them! They just look
> > similar when lines are added.
> Argh. Consider sending unified diffs, I think others prefer them too.
> When I see context diffs, I usually end up converting it to unified...
OK. On emacs-devel, RMS asks for context diffs but I guess it's the
maintainer's prerogative to choose.
> Anyway, I ended up checking the attached:
Thanks.
--
Nick http://www.inet.net.nz/~nickrob