This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch]: Add endianess to valprint routines

From: Markus Deuling <deuling at de dot ibm dot com>
To: Ulrich Weigand <uweigand at de dot ibm dot com>
Cc: GDB Patches <gdb-patches at sourceware dot org>
Date: Fri, 23 May 2008 06:29:03 +0200
Subject: Re: [patch]: Add endianess to valprint routines
References: <200805211514.m4LFEW6N002120@d12av02.megacenter.de.ibm.com>

Hi Uli,

Ulrich Weigand schrieb:

Markus Deuling wrote:

	* valprint.c (print_hex_chars, print_octal_chars, print_decimal_chars,
	print_binary_chars, print_char_chars): Add byte_order parameter and
	replace gdbarch_byte_order.
	(print_decimal_chars): Replace START_P, NOT_END_P and NEXT_P by their
	expressions and remove them. Remove unused TWO_TO_FOURTH.
	(val_print_type_code_int): Introduce gdbarch_byte_order to get at the
	endianness. Update call to print_hex_chars.
	* valprint.h (print_hex_chars, print_octal_chars, print_decimal_chars,
	print_binary_chars, print_char_chars): Add byte_order parameter.
	* printcmd.c (print_scalar_formatted): Introduce gdbarch_byte_order to
	get at the endianness. Update print_*_char calls to use byte_order.


Minor coding style issue in the ChangeLog: please always use two spaces
after '.'.

Otherwise, this is OK.

Thanks,
Ulrich

thank you. Committed with a reworked ChangeLog.

Regards,
Markus


--
 Markus Deuling
 GNU Toolchain for Linux on Cell BE
 deuling@de.ibm.com

References:
- Re: [patch]: Add endianess to valprint routines
  - From: Ulrich Weigand

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]