This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch/mdebug] symbol symtab not set on Tru64
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 26 May 2008 09:18:09 -0700
- Subject: [patch/mdebug] symbol symtab not set on Tru64
Hello,
Something I just noticed while working on alpha-tru64. When reading
symbols from ECOFF, the produced symbols do not have their symtab
field set. I did a little of archeology, and basically the reason
for it is because the symbol reader does its own symbol and symtab
building, rather than using buildsym. So when the symtab field
was added to struct symbol, we forgot to update part of mdebugread.c.
It's kind of confusing, because mdebugread also handles stabs-in-coff,
in which case buildsym.c is being used. This may be why we missed
the parts in mdebugread.c that needed an update.
As a result, we end up with SEGVs or failed assertions when trying
to access this field because it was NULL. Fixed thusly.
2008-05-26 Joel Brobecker <brobecker@adacore.com>
Set the symtab field of symbols read from ECOFF debugging entries.
* mdebugread.c (add_symbol): Add new parameter symtab.
(parse_symbol): Update calls to add_symbol throughout.
Tested on alpha-tru64 with the AdaCore testsuite (I can't seem to get
expect to work on Tru64 anymore - it looks like I have an echo issue).
I will commit in a week unless there are comments about the patch.
--
Joel