This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] 2/3: Fix crash on self-looping DW_OP_fbreg


On Sun, May 04, 2008 at 03:14:03PM +0200, Jan Kratochvil wrote:
> On Thu, 01 May 2008 22:29:04 +0200, Daniel Jacobowitz wrote:
> ...
> > OK.  Do we need a cleanup for this though?  If we error out, we won't
> > get back until we create a new context, so missing the decrement
> > is not a problem.
> 
> I find it too fragile relying only on the current callers of DWARF_EXPR_EVAL.
> There may be a hard to catch bug after someone wraps some part of the code by
> CATCH_EXCEPTIONS and expects DWARF_EXPR_CONTEXT passed into the
> CATCH_EXCEPTIONS block will stay uncorrupted afterwards.
> 
> Attached a discouraged simplified patch not using the exception system.

Thanks.  Could you please commit this version?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]