This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Patch to limit field name completion candidates


>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:

>> We aren't parsing complete expressions, true, but I think by the time
>> the COMPLETE token is reduced, we will have reduced the entire LHS of
>> the struct op expression.  And, we throw away the rest of the
>> expression -- all the malformed parts.
>> 
>> So, I think it ought to be safe in all cases.

Daniel> Safe, yes.  That's not the failure mode I was worried about.  I'm
Daniel> wondering if we will ever error out before we reduce the COMPLETE.
Daniel> But it seems to work so far.

In that case, nothing will call mark_struct_expression, and so the
completion machinery will not attempt field name completion.

Daniel> Another example near the bottom of Command Completion would probably
Daniel> do it.

Ok.  I will add this.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]