This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFC] gnu-nat.c: possibly fix "info threads" test failures


Here you are:
but as I said, I cannot even compile
gdb that is using this... far less
run the testsuite.
 There might also be some specific test that,
on the contrary relies on the lower case "thread"
to pass.

  Anyhow, I am willing to commit this
if anyone either tests it or takes the
responsibility to accept it without testing...


Pierre Muller
Pascal language support maintainer for GDB



ChangeLog entry:

2008-12-19  Pierre Muller  <muller@ics.u-strasbg.fr>

        * gnu-nat.c (proc_string): Use capital T for "Thread".



$ cat gnu-nat-thread.patch
Index: gdb/gnu-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/gnu-nat.c,v
retrieving revision 1.46
diff -u -p -r1.46 gnu-nat.c
--- gdb/gnu-nat.c       1 Jan 2008 22:53:10 -0000       1.46
+++ gdb/gnu-nat.c       19 Jun 2008 16:24:36 -0000
@@ -2556,7 +2556,7 @@ proc_string (struct proc *proc)
   if (proc_is_task (proc))
     sprintf (tid_str, "process %d", proc->inf->pid);
   else
-    sprintf (tid_str, "thread %d.%d",
+    sprintf (tid_str, "Thread %d.%d",
             proc->inf->pid, pid_to_thread_id (MERGEPID (proc->tid, 0)));
   return tid_str;
 }


> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Daniel Jacobowitz
> Envoyé?: Thursday, June 19, 2008 3:57 PM
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFC] win32-nat.c: fix "info threads" test failures
> 
> On Thu, Jun 19, 2008 at 08:43:09AM +0200, Pierre Muller wrote:
> > Thanks,
> > committed now.
> >
> > Should I submit a similar patch for gnu-nat.c?
> > The main problem is that I have no way to
> > run a testsuite that would use the modified code...
> 
> I think you should go ahead.
> 
> --
> Daniel Jacobowitz
> CodeSourcery



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]