This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch]: Fix memory leak of c-exp.y

From: Daniel Jacobowitz <drow at false dot org>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: teawater <teawater at gmail dot com>, gdb-patches at sourceware dot org, Jan Kratochvil <jan dot kratochvil at redhat dot com>
Date: Wed, 25 Jun 2008 09:31:39 -0400
Subject: Re: [patch]: Fix memory leak of c-exp.y
References: <daef60380806232332n429917efu4eec3c7ca1731987@mail.gmail.com> <20080625124303.GB3700@adacore.com>

On Wed, Jun 25, 2008 at 08:43:03AM -0400, Joel Brobecker wrote:
> Hi teawater,
> 
> > 2008-06-21  Hui Zhu <teawater@gmail.com>
> >        * gdb/c-exp.y: Fix memory leak of function parse_number
> 
> Instead of adding calls to free, I looks like this string is actually
> completely local, so how about replacing the call to malloc with a
> call to alloca, and then get rid of all calls to free instead?

Let's go with Jan's version for now - he's fixed a few related
problems in the same function.  Jan, that patch is OK.

-- 
Daniel Jacobowitz
CodeSourcery

References:
- [patch]: Fix memory leak of c-exp.y
  - From: teawater
- Re: [patch]: Fix memory leak of c-exp.y
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]