This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MI] report pass for resuming commands
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sat, 28 Jun 2008 15:34:12 +0400
- Subject: Re: [MI] report pass for resuming commands
- References: <200806281416.04427.vladimir@codesourcery.com>
On Saturday 28 June 2008 14:16:04 Vladimir Prus wrote:
>
> I've noticed that the test helper routine for sending resuming commands
> fails to report passes. Fixes by attached commit.
Doh! This patch was the most obvious patch in the world, so I've neglected
to run the tests -- which, of course, failed. Reverted thusly, with comment.
- Volodya
Index: gdb/testsuite/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.1669
diff -u -p -r1.1669 ChangeLog
--- gdb/testsuite/ChangeLog 28 Jun 2008 11:15:34 -0000 1.1669
+++ gdb/testsuite/ChangeLog 28 Jun 2008 11:30:33 -0000
@@ -1,3 +1,8 @@
+2008-06-28 Vladimir Prus <vladimir@codesourcery.com>
+
+ * lib/mi-support.exp (mi_send_resuming_command_raw): Revert
+ previous commit. Add a comment.
+
2008-06-28 Pedro Alves <pedro@codesourcery.com>
* gdb.base/sigchld.c, gdb.base/sigchld.exp: New test.
Index: gdb/testsuite/lib/mi-support.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/mi-support.exp,v
retrieving revision 1.64
diff -u -p -r1.64 mi-support.exp
--- gdb/testsuite/lib/mi-support.exp 28 Jun 2008 10:14:34 -0000 1.64
+++ gdb/testsuite/lib/mi-support.exp 28 Jun 2008 11:30:33 -0000
@@ -1398,7 +1398,15 @@ proc mi_send_resuming_command_raw {comma
send_gdb "$command\n"
gdb_expect {
-re "\\^running\r\n\\*running,thread-id=\"\[^\"\]+\"\r\n${mi_gdb_prompt}" {
- pass "$test"
+ # Note that lack of 'pass' call here -- this works around limitation
+ # in DejaGNU xfail mechanism. mi-until.exp has this:
+ #
+ # setup_kfail gdb/2104 "*-*-*"
+ # mi_execute_to ...
+ #
+ # and mi_execute_to uses mi_send_resuming_command. If we use 'pass' here,
+ # it will reset kfail, so when the actual test fails, it will be flagged
+ # as real failure.
}
-re ".*${mi_gdb_prompt}" {
fail "$test (failed to resume)"