This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MI non-stop 04/11] Implement --thread and --frame.
- From: Daniel Jacobowitz <drow at false dot org>
- To: gdb-patches at sourceware dot org
- Date: Fri, 11 Jul 2008 08:49:50 -0400
- Subject: Re: [MI non-stop 04/11] Implement --thread and --frame.
- References: <200806282044.14246.vladimir@codesourcery.com>
On Sat, Jun 28, 2008 at 08:44:14PM +0400, Vladimir Prus wrote:
>
> This implements the --thread and --frame options to all MI command.
> Please see http://article.gmane.org/gmane.comp.gdb.devel/23414/ for
> background design for --thread. The --frame is ideologically same
> as --thread.
>
> The only non-MI change here is making find_thread_pid exported from
> thread.c, which change seems obvious, so no approval is needed. Comments,
> however, are much appreciated.
There were a lot of comments on this patch, so I'll only skim
it... might want to post an updated version.
> + if (strncmp (chp, "--thread", 8) == 0)
> + {
> + if (parse->thread != -1)
> + error ("Duplicate '--thread' option");
> + chp += 8;
> + parse->thread = strtol (chp, &chp, 10);
> + }
Someone may have mentioned this, but I think you should check for
"--thread " and "--frame " with trailing space.
--
Daniel Jacobowitz
CodeSourcery