This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Remove frame_sp_unwind
- From: Daniel Jacobowitz <drow at false dot org>
- To: gdb-patches at sourceware dot org
- Date: Tue, 15 Jul 2008 14:50:54 -0400
- Subject: [commit] Remove frame_sp_unwind
Unused. Tested on x86_64-linux and committed.
--
Daniel Jacobowitz
CodeSourcery
2008-07-15 Daniel Jacobowitz <dan@codesourcery.com>
* frame.c (frame_sp_unwind): Delete.
(get_frame_sp): Do not use it.
* frame.h (frame_sp_unwind): Delete prototype.
---
gdb/frame.c | 16 ++++++----------
gdb/frame.h | 2 --
2 files changed, 6 insertions(+), 12 deletions(-)
Index: src/gdb/frame.c
===================================================================
--- src.orig/gdb/frame.c 2008-06-30 14:38:21.000000000 -0400
+++ src/gdb/frame.c 2008-06-30 14:38:33.000000000 -0400
@@ -1747,22 +1747,18 @@ get_frame_arch (struct frame_info *this_
CORE_ADDR
get_frame_sp (struct frame_info *this_frame)
{
- return frame_sp_unwind (this_frame->next);
-}
-
-CORE_ADDR
-frame_sp_unwind (struct frame_info *next_frame)
-{
- struct gdbarch *gdbarch = get_frame_arch (next_frame);
+ struct gdbarch *gdbarch = get_frame_arch (this_frame);
/* Normality - an architecture that provides a way of obtaining any
frame inner-most address. */
if (gdbarch_unwind_sp_p (gdbarch))
- return gdbarch_unwind_sp (gdbarch, next_frame);
+ /* NOTE drow/2008-06-28: gdbarch_unwind_sp could be converted to
+ operate on THIS_FRAME now. */
+ return gdbarch_unwind_sp (gdbarch, this_frame->next);
/* Now things are really are grim. Hope that the value returned by
the gdbarch_sp_regnum register is meaningful. */
if (gdbarch_sp_regnum (gdbarch) >= 0)
- return frame_unwind_register_unsigned (next_frame,
- gdbarch_sp_regnum (gdbarch));
+ return get_frame_register_unsigned (this_frame,
+ gdbarch_sp_regnum (gdbarch));
internal_error (__FILE__, __LINE__, _("Missing unwind SP method"));
}
Index: src/gdb/frame.h
===================================================================
--- src.orig/gdb/frame.h 2008-06-30 14:38:21.000000000 -0400
+++ src/gdb/frame.h 2008-06-30 14:38:33.000000000 -0400
@@ -285,8 +285,6 @@ extern CORE_ADDR get_frame_address_in_bl
known as top-of-stack. */
extern CORE_ADDR get_frame_sp (struct frame_info *);
-extern CORE_ADDR frame_sp_unwind (struct frame_info *);
-
/* Following on from the `resume' address. Return the entry point
address of the function containing that resume address, or zero if