Re: RFA: Remove gdb-events

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> Eli: if you could take a look at the documentation of the new
Joel> observers, that would be great! I'm going to approve the
Joel> technical part, and we'll follow any suggestion you might have
Joel> either before or after commit.

Joel> Vladimir: This patch touches MI. Could you take a look at this part
Joel> of the patch? The changes seem fine to me, but see below my suggestion.

I'm waiting for these two, so I haven't sent an updated patch.
But...

Joel> First nit: gdbarch.c is a generated file. You'll need to modify
Joel> gdbarch.sh instead, and regenerate gdbarch.c. You'll see that
Joel> the changes should be identical to the ones you made, but in a
Joel> different file.

Thanks, I fixed this.

>> +++ Makefile.in	13 Jul 2008 00:04:57 -0000

Joel> For this part, could you re-do a pass to check that the dependencies
Joel> have all been correctly updated. For instance, I noticed that for
Joel> tracepoint.c, you correctly removed the dependency on gdb-events.h,
Joel> but forgot to add the one on observer.h. As far as I can tell, this
Joel> is the only case were something was missed.

I checked and all the dependencies are there, afaict.  I think you
just misread the tracepoint.o hunk.  See the second insertion:

@@ -2933,9 +2930,9 @@
 tracepoint.o: tracepoint.c $(defs_h) $(symtab_h) $(frame_h) $(gdbtypes_h) \
 	$(expression_h) $(gdbcmd_h) $(value_h) $(target_h) $(language_h) \
 	$(gdb_string_h) $(inferior_h) $(tracepoint_h) $(remote_h) \
-	$(linespec_h) $(regcache_h) $(completer_h) $(gdb_events_h) \
+	$(linespec_h) $(regcache_h) $(completer_h) \
 	$(block_h) $(dictionary_h) $(ax_h) $(ax_gdb_h) $(readline_h) \
-	$(readline_history_h)
+	$(readline_history_h) $(observer_h)
 trad-frame.o: trad-frame.c $(defs_h) $(frame_h) $(trad_frame_h) \
 	$(regcache_h) $(frame_unwind_h) $(value_h)
 tramp-frame.o: tramp-frame.c $(defs_h) $(tramp_frame_h) $(frame_unwind_h) \


thanks,
Tom