Re: [RFA] set print symbol-loading on|off

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Wed, 23 Jul 2008 15:41:08 -0700
> From: "Doug Evans" <dje@google.com>
> Cc: gdb-patches@sourceware.org
> 
> > > -       printf_unfiltered (_("Reading symbols from %s..."), name);
> > > -       wrap_here ("");
> > > -       gdb_flush (gdb_stdout);
> > > +          if (print_symbol_loading)
> > > +         {
> > > +           printf_unfiltered (_("Reading symbols from %s..."), name);
> > > +           wrap_here ("");
> > > +           gdb_flush (gdb_stdout);
> > > +         }
> >
> > I'm not sure doing this in complete silence is a good idea.  You've
> > shut up GDB, but this phase could take a long time, during which GDB
> > will appear to be hung.  How about printing a single message, like
> > "Reading symbols ..."?
> 
> Any ideas where such a message should be printed? I'm guessing you'd want it
> printed in all the user-commands that might call this lowish-level routine,
> but that's just a guess.

Yes, that'd be a good place.  Or you could it right here, with some
variable keeping track of whether this message was already printed.

> Monkey-see monkey-do hacking from the "set print thread-events" patch.  Any
> suggestions if/how that needs to be enhanced as well?

It could use a similar enhancement, yes, although it does slightly
better than your original text, since it actually gives a few examples
of the events to be announced.

As for how to enhance it, I'd move the list of events to the detailed
description, and make the list exhaustive.  How does that sound?

Thanks.