This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [2/7] Add the attached-to thread in inf_ptrace_attach
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: pedro at codesourcery dot com
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 8 Aug 2008 23:48:14 +0200 (CEST)
- Subject: Re: [2/7] Add the attached-to thread in inf_ptrace_attach
- References: <200808080235.13509.pedro@codesourcery.com>
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Fri, 8 Aug 2008 02:35:13 +0100
>
> This patch makes sure that the thread/task we attach to with ptrace
> targets is added to GDB's thread table. Targets that extend
> inf-ptrace (inf_ptrace_target) should then use thread_change_ptid
> as soon as then have more lwp or tid info, instead of just setting
> inferior_ptid. Targets that don't have a process_stratum target
> overriding inf_ptrace_attach get it for free (BSD targets).
>
> This was tested together with the rest of the series on
> x86_64-unknown-linux-gnu, i386-unknown-openbsd4.3, i386-unknown-freebsd6.0
> and i386-unknown-freebsd7.0.
>
> OK?
Had the inf-ptrace.c bit in my tree too. So that's defenitely ok.
I always get headaches when I look at linux-nat.c, so I'll trust you
on that one.
> 2008-08-08 Pedro Alves <pedro@codesourcery.com>
>
> * inf-ptrace.c: Include "gdbthread.h".
> (inf_ptrace_attach): Add the main thread here.
> * linux-nat.c (linux_nat_attach): Don't add the main thread here.
> Decorate the main thread id with the lwp id.