This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [4/7] Adjust the ttrace target (HP-UX) to always register the
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: drow at false dot org (Daniel Jacobowitz)
- Cc: pedro at codesourcery dot com, gdb-patches at sourceware dot org
- Date: Sat, 9 Aug 2008 20:35:50 -0400 (EDT)
- Subject: Re: [4/7] Adjust the ttrace target (HP-UX) to always register the
> My understanding is that 1/7, 2/7, 7/7 are approved; 3/7 has a small
> discussion; 4/7 has a big discussion; and no one's looked at 5/7 or
> 6/7 yet. I'll look at those as soon as I get a chance, so poke me if
> 3/7 and 4/7 are resolved and I haven't done it yet.
I've just tried Pedro's second and third patches for 4/7. These
apply on top of the corrected first patch. There are a couple of
typos. Once these are fixed, the set seems to work (i.e., they
fix the problem of ttrace errors when resuming threads).
There is a typo in the second patch here:
+ info = thread_find_pid (ptid);
This should be find_thread_pid.
The second typo is in the thread patch:
+ printf_unfiltered(_("[%s has been terminated]\n")
+ target_pid_to_str (ptid));
There's a missing ",'.
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)