This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Patches to build on DJGPP
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: pedro at codesourcery dot com
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 10 Aug 2008 17:36:39 +0200 (CEST)
- Subject: Re: Patches to build on DJGPP
- References: <200808092241.46195.pedro@codesourcery.com>
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Sat, 9 Aug 2008 22:41:46 +0100
>
> gdb/
> 2008-08-09 Pedro Alves <pedro@codesourcery.com>
>
> * buildsym.c (start_subfile): Cast sentinel NULL to void*.
> * cp-name-parser.y: Include "config.h".
> * posix-hdep.c [__GO32__]: Include time.h.
> * xml-tdesc.c (fetch_xml_from_file): Cast sentinel NULL to void*.
> * gdb_select.h: Include sys/types.h if available.
>
> readline/
> 2008-08-09 Pedro Alves <pedro@codesourcery.com>
>
> * signals.c (rl_set_sighandler): Guard access to SIGWINCH.
> * wcwidth.c [__GO32__]: Include wctype.h before wchar.h.
>
> bfd/
> 2008-08-09 Pedro Alves <pedro@codesourcery.com>
>
> * archive.c (_bfd_archive_bsd_update_armap_timestamp): Cast stat
> st_mtime to long before comparison.
>
> Index: src/gdb/buildsym.c
> ===================================================================
> --- src.orig/gdb/buildsym.c 2008-08-09 20:55:28.000000000 +0100
> +++ src/gdb/buildsym.c 2008-08-09 22:27:04.000000000 +0100
> @@ -547,7 +547,7 @@ start_subfile (char *name, char *dirname
> && !IS_ABSOLUTE_PATH (subfile->name)
> && subfile->dirname != NULL)
> subfile_name = concat (subfile->dirname, SLASH_STRING,
> - subfile->name, NULL);
> + subfile->name, (void*) NULL);
> else
> subfile_name = subfile->name;
>
There's a space missing; should be (void *) instead of (void*).
However, I think one can argue that one should use (char *) here.
Same for xml-tdep.c further down.
> Index: src/gdb/cp-name-parser.y
> ===================================================================
> --- src.orig/gdb/cp-name-parser.y 2008-08-09 20:55:32.000000000 +0100
> +++ src/gdb/cp-name-parser.y 2008-08-09 22:27:04.000000000 +0100
> @@ -36,6 +36,7 @@ Boston, MA 02110-1301, USA. */
> #include <unistd.h>
> #include <string.h>
>
> +#include "config.h"
> #include "safe-ctype.h"
> #include "libiberty.h"
> #include "demangle.h"
Hmm, is there a reason not to include "defs.h" here?
> Index: src/gdb/posix-hdep.c
> ===================================================================
> --- src.orig/gdb/posix-hdep.c 2008-08-09 20:55:39.000000000 +0100
> +++ src/gdb/posix-hdep.c 2008-08-09 22:27:04.000000000 +0100
> @@ -24,6 +24,12 @@
>
> #include "gdb_select.h"
>
> +#ifdef __GO32__
> +/* DJGPP defines the fd_set type in sys/types.h, but `select' goes
> + here. */
> +# include <time.h>
> +#endif
> +
> /* The strerror() function can return NULL for errno values that are
> out of range. Provide a "safe" version that always returns a
> printable string. */
Like I wrote in another reply, I think we should include <sys/time.h>
in gdb_select.h, instead of adding this #ifdef __GO32__ here.
> Index: src/gdb/xml-tdesc.c
> ===================================================================
> --- src.orig/gdb/xml-tdesc.c 2008-08-09 20:55:45.000000000 +0100
> +++ src/gdb/xml-tdesc.c 2008-08-09 22:27:04.000000000 +0100
> @@ -443,7 +443,7 @@ fetch_xml_from_file (const char *filenam
>
> if (dirname && *dirname)
> {
> - char *fullname = concat (dirname, "/", filename, NULL);
> + char *fullname = concat (dirname, "/", filename, (void*) NULL);
> if (fullname == NULL)
> nomem (0);
> file = fopen (fullname, FOPEN_RT);