This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH-ppc 1/5] Add basic support for new VSX register set
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: uweigand at de dot ibm dot com (Ulrich Weigand)
- Cc: luisgpm at linux dot vnet dot ibm dot com, bauerman at br dot ibm dot com (Thiago Jung Bauermann), gdb-patches at sourceware dot org
- Date: Thu, 14 Aug 2008 21:59:08 +0200 (CEST)
- Subject: Re: [PATCH-ppc 1/5] Add basic support for new VSX register set
> > + t = init_composite_type ("__ppc_builtin_type_vec128", TYPE_CODE_UNION);
> > + append_composite_type_field (t, "uint128", builtin_type_uint128);
> > + append_composite_type_field (t, "v4_float",
> > + init_vector_type (builtin_type_float, 4));
> > + append_composite_type_field (t, "v4_int32",
> > + init_vector_type (builtin_type_int32, 4));
> > + append_composite_type_field (t, "v8_int16",
> > + init_vector_type (builtin_type_int16, 8));
> > + append_composite_type_field (t, "v16_int8",
> > + init_vector_type (builtin_type_int8, 16));
>
> Please use builtin_type (gdbarch)->builtin_... instead of builtin_type_...
> I'm just trying to get rid of those ...
This might have been a bit confusing: the platform-independent types like
builtin_type_int8 are of course fine to use. I was referring to the
platform-dependent types like builtin_type_float (and builtin_type_double
that you're using elsewhere).
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com