This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: fix PR 1535
On Thu, Aug 14, 2008 at 05:23:54PM -0600, Tom Tromey wrote:
> How pedantically C is gdb? Here I cast some small integers to
> 'void*'. Alternatively I could turn the "context" into a union, or
> make some globals.
Go through uintptr_t, please. I've made stdint.h always available and that
will be the right size; if you go int -> void * you will break
x86_64. Well, you tested x86_64. But I'm not sure why you didn't get
a warning for (void *) 1.
> Also, I notice that hardly anything else uses the 'sfunc' code. Is
> the intent to restrict this just to 'set' functions? IOW, is this an
> abuse?
I dont know, but it looks entirely reasonable to me. Patch is OK.
--
Daniel Jacobowitz
CodeSourcery