This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: remote-mips.c, always a thread
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 18 Aug 2008 14:07:34 +0100
- Subject: Re: remote-mips.c, always a thread
- References: <200808181329.28252.pedro@codesourcery.com>
On Monday 18 August 2008 13:29:28, Pedro Alves wrote:
> - mips_load was clearing inferior_ptid, and calling clear_symtab_users. I
> notice that inferior_ptid is being cleared after a load command, but that
> is wrong, I believe. See this change of Jim's to monitor.c, that removed
> this clearing from the monitor target:
> http://sourceware.org/ml/gdb/2001-09/msg00125.html
>
> I'm applying the exact same reasoning and change here.
>
Hmmm, I just noticed that mips_kill is being used to interrupting
the target ( '\03' / ^C / SIGINT ), instead of installing a SIGINT
handler like at least monitor.c, remote.c and remote-sim.c do.
This looks broken to me -- target_kill is definitelly not the
right target method for this (and neither is the "kill" command).
> This hasn't been tested at all, but, does it looks reasonable?
I forgot to add a new target_thread_alive function, otherwise,
info threads gets rid of the thread I just added.
--
Pedro Alves