This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] add ppc testcase to test fpscr


On Wed, Sep 03, 2008 at 05:12:25PM -0300, Thiago Jung Bauermann wrote:
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {quiet debug additional_flags=-O0}] != "" } {

No need for additional_flags here.

> +# Run the program, when the prompt comes back it will be for the invalid
> +# operation breakpoint.
> +gdb_run_cmd

You've got to wait for the prompt explicitly.  If you ever leave expect
in a state where two prompts should be arriving, it won't know which
is which; if it sees them separately, you can get out of sync and all
tests will fail with unknown output.  That's one advantage of using
runto_main followed by an explicit continue.

Looks otherwise OK to me.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]