This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] add ppc testcase to test fpscr
- From: Daniel Jacobowitz <drow at false dot org>
- To: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Wed, 3 Sep 2008 17:00:54 -0400
- Subject: Re: [rfc] add ppc testcase to test fpscr
- References: <1219360611.8989.6.camel@localhost.localdomain> <20080821233115.GA1239@caradoc.them.org> <1219362081.29526.2.camel@localhost.localdomain> <20080822024659.GA12951@caradoc.them.org> <1219428669.8167.2.camel@localhost.localdomain> <20080902215458.GB25623@caradoc.them.org> <1220472745.9671.13.camel@localhost.localdomain>
On Wed, Sep 03, 2008 at 05:12:25PM -0300, Thiago Jung Bauermann wrote:
> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {quiet debug additional_flags=-O0}] != "" } {
No need for additional_flags here.
> +# Run the program, when the prompt comes back it will be for the invalid
> +# operation breakpoint.
> +gdb_run_cmd
You've got to wait for the prompt explicitly. If you ever leave expect
in a state where two prompts should be arriving, it won't know which
is which; if it sees them separately, you can get out of sync and all
tests will fail with unknown output. That's one advantage of using
runto_main followed by an explicit continue.
Looks otherwise OK to me.
--
Daniel Jacobowitz
CodeSourcery