This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] rename paddr_[du] to p{,u}longest


Doug Evans wrote:

> Hi.  paddr_[du] claim to print addresses (CORE_ADDR) given their name but they
> are really intended to support printing {,U}LONGEST values.
> This patch renames them to plongest/pulongest, and changes the type of
> the unsigned printer from CORE_ADDR to ULONGEST to support printing
> 64 bit unsigned values when CORE_ADDR is 32-bits (decimal2str takes
> a ULONGEST parameter so there's no real reason why pulongest(/paddr_u)
> can't take a ULONGEST too).

Agreed.  This has annoyed me on occasion as well ...

> 2008-09-04  Doug Evans  <dje@google.com>
> 
> 	* defs.h (plongest,pulongest): Renamed from paddr_u,paddr_d.
> 	Change argument of pulongest from CORE_ADDR to ULONGEST.
> 	All callers updated.
> 	* utils.c (plongest): Renamed from paddr_d.
> 	(pulongest): Renamed from paddr_u, change arg type to ULONGEST.
> 	* remote-mips.c (send_srec): Use paddr_nz instead of paddr_u in
> 	`CORE_ADDR addr' arg of error message.

This is OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]