This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] remove extra verbose -log calls in testcases


> As noticed by Joel in my FPSCR testcase, it's not usual to call verbose
> twice. Committed the following.

I ended up having a look at the dejagnu documentation about this verbose
procedure, and here is what it says:

    | Verbose Procedure
    | 
    | Test cases can use this function to issue helpful messages
    | depending on the number of --verbose options on the runtest
    | command line. It prints string if the value of the variable
    | verbose is higher than or equal to the optional number. The
    | default value for number is 1. Use the optional -log argument to
    | cause string to always be added to the log file, even if it won't
    | be printed. Use the optional -x argument to log the test results
    | into a parsable XML file. Use the optional -n argument to print
    | string without a trailing newline. Use the optional -- argument
    | if string begins with "-".
    | 
    | verbose(-log -x -n -r string number);

So I think it is indeed wrong to have duplicate calls to verbose.

I like the fact that -log causes it to always be printed to the log
file, but I don't see this as very important... Since the vast majority
of the testcase I inspected seem to use the verbose procedure without
-log, at least we're consistent...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]