This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc][00/37] Eliminate builtin_type_ macros


Joel Brobecker wrote:

> Sure! I don't know what this didn't cross my mind earlier, I guess
> I was in a bit of a crunch... Will do that tomorrow (I'm also planning
> on submitting a bunch of patches tomorrow as well, if things go as
> planned - so that'll be a good time for that).

OK, thanks!

> It was on top of your patch - If I am not mistaken, it should apply
> cleanly after you apply yours. I did, however, generate the patch
> against AdaCore's gdb-head (which is a merge between our changes
> and nearly-top-of-fsf-tree) to which I applied your patch.  So there
> might indeed be some differences that would cause a conflict; I just
> don't see any, right now.

Your version has:

> > > +        return value_from_longest (builtin_type_int32,
> > >                                     TARGET_CHAR_BIT * TYPE_LENGTH (type));

which causes the problem with the re-used "type" variable.

The current gdb-head version has:

> >         return value_from_longest (builtin_type_int,
> >                                    TARGET_CHAR_BIT
> >                                    * TYPE_LENGTH (value_type (arg1)));

instead, where this problem does not occur.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]