This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RFA: fix stray use of printf_filtered
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 22 Sep 2008 11:34:34 -0600
- Subject: RFA: fix stray use of printf_filtered
- Reply-to: tromey at redhat dot com
I noticed that when I attach to a large program, gdb will paginate the
"Reading symbols" messages at odd places.
I tracked this down to a printf_filtered in
symbol_file_add_with_addrs_or_offsets. The other prints in this
function are all unfiltered, and I think this one ought to be as well.
The change snuck in here:
http://sourceware.org/ml/gdb-patches/2004-07/msg00497.html
I think it was probably unintentional.
Built and regtested on x86-64 (compile farm).
Please review.
Tom
:ADDPATCH symbols:
2008-09-22 Tom Tromey <tromey@redhat.com>
* symfile.c (symbol_file_add_with_addrs_or_offsets): Don't use
printf_filtered.
diff --git a/gdb/symfile.c b/gdb/symfile.c
index d067d2b..656b5a9 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -1065,11 +1065,11 @@ symbol_file_add_with_addrs_or_offsets (bfd *abfd, int from_tty,
&& print_symbol_loading)
{
wrap_here ("");
- printf_filtered (_("(no debugging symbols found)"));
+ printf_unfiltered (_("(no debugging symbols found)"));
if (from_tty || info_verbose)
- printf_filtered ("...");
+ printf_unfiltered ("...");
else
- printf_filtered ("\n");
+ printf_unfiltered ("\n");
wrap_here ("");
}