This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix argument-passing error in linux-nat.c
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: SÃrgio Durigan JÃnior <sergiodj at linux dot vnet dot ibm dot com>
- Date: Thu, 25 Sep 2008 14:52:19 +0100
- Subject: Re: [PATCH] Fix argument-passing error in linux-nat.c
- References: <1222348523.10481.5.camel@miki>
On Thursday 25 September 2008 14:15:23, SÃrgio Durigan JÃnior wrote:
> This is a very trivial patch that I have done (while I don't have yet
> the 'catch syscall' patch! :D). Well, I found this little error in
> linux-nat.c. Basically, the 'status' variable in the function
> 'get_pending_status' is a pointer to an integer, but the macros from
> waitpid.h (WIFSTOPPED and WSTOPSIG) are being called with this pointer
> as the argument, instead of the integer itself. It was just a matter of
> putting a '*' in the front of the name ;-)
Well, I'll be ... Your change is obviously correct. Can you check it in,
with a ChangeLog entry?
How many typos can one write. :-) Sorry 'bout that.
> This fix did not cause any improvement on the testsuite (for 32-bit PPC
> at least), but anyway it's better to do things right, huh?
You can only trigger this code path in non-stop mode (set
target-async + set non-stop 1), and we don't have any non-stop test
attach/detaching.
--
Pedro Alves