This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [reverse RFA] Remove process record warning code


I'm worried that the naive user might think that he can
extend a recording session across several runs.

Might seem counter-intuitive, but I think the SID reverse
execution implementation will allow you to do that.  If you
run the inferior multiple times, you can actually "back up"
into a previous execution.

I know Process Record won't let you do that, I'm just
saying, a user's intuition is not necessarily the same
as yours or mine...

teawater wrote:
I think user already know P record will stop when inferior exit. So...

How do you think about it?


On Sat, Oct 18, 2008 at 01:23, Michael Snyder <msnyder@vmware.com> wrote:
You don't think you need this special warning?

teawater wrote:
Hi Michael,

2008-10-17 Hui Zhu <teawater@gmail.com>

       * infcmd.c (kill_if_already_running): Remove process record
       warning code.

Thanks,
Hui


------------------------------------------------------------------------


--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-10-17  Hui Zhu  <teawater@gmail.com>
+
+       * infcmd.c (kill_if_already_running): Remove process record
+       warning code.
+
 2008-10-15  Hui Zhu  <teawater@gmail.com>
         Change "record-auto-delete" to "record-stop-at-limit".
--- a/infcmd.c
+++ b/infcmd.c
@@ -51,7 +51,6 @@
 #include "exceptions.h"
 #include "cli/cli-decode.h"
 #include "gdbthread.h"
-#include "record.h"
  /* Functions exported for general use, in inferior.h: */
 @@ -427,12 +426,8 @@ kill_if_already_running (int from_tty)
        restart it.  */
      target_require_runnable ();
 -      if (from_tty)
-       if (!query (RECORD_IS_USED ?
-                   "The program being debugged has been started
already,\n\
-and is running in record/replay mode.  Do you want to abandon\n\
-the recording and start the program from the beginning? " :
-                   "The program being debugged has been started
already.\n\
+      if (from_tty
+         && !query ("The program being debugged has been started
already.\n\
 Start it from the beginning? "))
         error (_("Program not restarted."));
      target_kill ();



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]