This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Convenience functions
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: rob dot quill at gmail dot com, gdb-patches at sourceware dot org
- Date: Fri, 24 Oct 2008 14:52:40 +0200
- Subject: Re: Convenience functions
- References: <baf6008d0801300405i47646b05pdb799d32ab71e005@mail.gmail.com> <u1w7zxjid.fsf@gnu.org> <8f2776cb0801301557t2e265b62u56d6df7cbcec1c84@mail.gmail.com> <utzkuws6q.fsf@gnu.org> <baf6008d0807271645o7d03dd94rd5b3f0d08302085a@mail.gmail.com> <m38wvk77qd.fsf@fleche.redhat.com> <baf6008d0807291404x255213b7id79efc6939d92eb1@mail.gmail.com> <m3bq0g59md.fsf@fleche.redhat.com> <20081023134150.GA21234@caradoc.them.org> <m3mygv1gwn.fsf@fleche.redhat.com> <20081023152146.GA29371@caradoc.them.org> <m3y70fyvjo.fsf@fleche.redhat.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Cc: gdb-patches@sourceware.org
> From: Tom Tromey <tromey@redhat.com>
> Date: Thu, 23 Oct 2008 13:13:15 -0600
>
> I did write some docs.
Thanks. I have two small requests for the documentation part:
> +Currently there is a single defined convenience function:
I would replace this with something more general, because we do hope
the list will grow. Once somebody adds another function, this
sentence will become obsolete, but we might forget to change it.
OTOH, everybody can count to 1, so in its current form the sentence is
redundant.
> +@item $in_scope (@var{name})
> +Evaluate to @samp{1} if the symbol @var{name} is defined in the
> +program, or @samp{0} otherwise.
I suggest to change @var{name} to @var{symbol}, and then the text
could be a little bit more concise:
Evaluate to @samp{1} if @var{symbol} is defined in the program, ...
By the way, is "defined in the program" accurate enough? The name
"in_scope" does mean ``in scope'', right? If so, I'd modify that
sentence to use ``in scope'' explicitly. "Defined in the program"
could mean defined somewhere outside the scope of $pc.
Thanks.