This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] fix thinko in sym info
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: ppluzhnikov at google dot com, gdb-patches at sourceware dot org
- Date: Wed, 19 Nov 2008 18:31:15 -0500
- Subject: Re: [RFA] fix thinko in sym info
- References: <20081119225237.1D8751C799D@localhost>
> The outstanding question is, of course, whether
>
> "%s + %u", msym_name, offset
>
> needs i18n. This patch assumes it doesn't.
I would tend to agree, although perhaps someone who has knowledge with
languages that write right-to-left might come up with a case where
they'd translate "SYMBOL + OFFSET" differently from the original.
In other words, I'm hoping that "SYMBOL + OFFSET" is international.
Also, I would think that the "SYMBOL + OFFSET" part is one entity
that would not be split during translation to any language. This is
derived from the assumption above.
> 2008-11-19 Doug Evans <dje@google.com>
>
> * printcmd.c (sym_info): Don't print the offset if it's zero.
In my opinion, that's fine. We can always fix the problem later if
someone comes up with a situation where the current approach is
too limited - that'd be pretty easy to do.
Any objection to this patch being applied?
--
Joel