This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to support spaces in filenames & paths


On Wed, Dec 10, 2008 at 04:31:48PM +0100, Denis PILAT wrote:
> I made some experiments with parse_to_comma_and_eval, but I think I must  
> be sure to understand what you need before going further in my  
> implementation, and summarize the situation

parse_to_comma_and_eval is only required for functions that take more
than one expression.  This doesn't, so it doesn't apply.

I see that buildargv is going to be a problem if the last argument is
a free-form expression.  I'm not entirely sure what to do about that.
Maybe a GDB-local version that extracts one argument string at a time
and returns that, plus a pointer to the next unparsed bit of the
command line.

The important thing, in my opinion, is to use the same handling of
quotes and spaces that buildargv does for consistency with other
commands, like "file".

Maybe we can solve this later and just use buildargv.  Compare with
add_symbol_file_command which takes an address.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]